BioJulia / FASTX.jl

Parse and process FASTA and FASTQ formatted files of biological sequences.
https://biojulia.dev
MIT License
61 stars 20 forks source link

Change fileld field of records to Int #69

Closed jakobnissen closed 2 years ago

jakobnissen commented 2 years ago

The filled field of records is now an integer. Since it was always 1:n before, there is no reason it's not just n. Is based on #68

codecov[bot] commented 2 years ago

Codecov Report

Merging #69 (561deda) into release-2 (216ef45) will decrease coverage by 1.67%. The diff coverage is 72.22%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-2      #69      +/-   ##
=============================================
- Coverage      80.63%   78.95%   -1.68%     
=============================================
  Files             12       12              
  Lines            661      632      -29     
=============================================
- Hits             533      499      -34     
- Misses           128      133       +5     
Flag Coverage Δ
unittests 78.95% <72.22%> (-1.68%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fastq/record.jl 78.22% <63.33%> (-4.17%) :arrow_down:
src/fasta/record.jl 59.37% <68.96%> (-5.88%) :arrow_down:
src/fasta/readrecord.jl 96.42% <100.00%> (ø)
src/fastq/fastqread.jl 100.00% <100.00%> (ø)
src/fastq/readrecord.jl 46.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 216ef45...561deda. Read the comment docs.

jakobnissen commented 2 years ago

Superseded by #68