BioJulia / FASTX.jl

Parse and process FASTA and FASTQ formatted files of biological sequences.
https://biojulia.dev
MIT License
61 stars 20 forks source link

Use ReTest #84

Closed kescobo closed 2 years ago

kescobo commented 2 years ago

Branched off of #68 . Closes #83

codecov[bot] commented 2 years ago

Codecov Report

Merging #84 (e252715) into master (f44c498) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          11       11           
  Lines         629      629           
=======================================
  Hits          568      568           
  Misses         61       61           
Flag Coverage Δ
unittests 90.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/FASTX.jl 91.17% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kescobo commented 2 years ago

@jakobnissen So this is a bummer

How married to the nesting testsets are you? I could preserve it by making each of the sub-files a new module (eg TestFASTA.IO - it would be a bit of a hassle since each thing would need to re-do imports etc. Another option is to just include the name in all of the testsets (eg @testset "IO - Reader Basics" begin. Then one can do `retest(TestFASTA, "IO") to run them in isolation.

I'm partial to the last one. You can pass multiple filters, so eg if you want the "basic" tests, but only the ones from "IO", you can do retest(TestFASTA, "IO", "basic").

kescobo commented 2 years ago

Argh, actually, that doesn't work as well because it doesn't pick up on changes to the included files with Revise. I'll just make submodules.

jakobnissen commented 2 years ago

I don't really have any opinions, since I haven't used ReTest for any real project yet.

kescobo commented 2 years ago

Alright, I think this should work. I've added a test/README.md to describe what to do, please take a look and let me know if it makes sense.

kescobo commented 2 years ago

Hm... don't see why julia 1.6 would be different here.

kescobo commented 2 years ago

Oh, the problem is windows/mac, not the julia version :thinking:

I only have linux box, anyone with mac/windows have a thought?

jakobnissen commented 2 years ago

It could be having different files whose names differ by case only? I think Windows paths are case insensitive

kescobo commented 2 years ago

@jakobnissen OK, I think this is good to go