CiaranOMara commented 4 years ago

This pull request contains general housekeeping. There are no code changes, just CI and documentation updates. Please let me know if I've missed something, if something doesn't make sense, or whether there are better CI implementations.

codecov[bot] commented 4 years ago

Codecov Report

Merging #22 into master will increase coverage by 12.73%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
+ Coverage    73.7%   86.43%   +12.73%     
===========================================
  Files          32       39        +7     
  Lines        1715     2050      +335     
===========================================
+ Hits         1264     1772      +508     
+ Misses        451      278      -173

Impacted Files	Coverage Δ
src/gff3/writer.jl	`50% <0%> (-16.67%)`	:arrow_down:
src/interval.jl	`69.23% <0%> (-4.3%)`	:arrow_down:
src/gff3/record.jl	`78.8% <0%> (-1.47%)`	:arrow_down:
src/gff3/gff3.jl	`100% <0%> (ø)`
src/indexes/indexes.jl	`100% <0%> (ø)`
src/bbi/bbi.jl	`100% <0%> (ø)`
src/bigbed/bigbed.jl	`100% <0%> (ø)`
src/bed/bed.jl	`100% <0%> (ø)`
src/bigwig/bigwig.jl	`100% <0%> (ø)`
src/GenomicFeatures.jl	`100% <0%> (ø)`
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e256b2...c724b78. Read the comment docs.

CiaranOMara commented 4 years ago

Probably worth waiting for https://github.com/BioJulia/Libz.jl/pull/66 to be released so that it can be added to the compat section here.

CiaranOMara commented 4 years ago

I like the idea of separating documentation builds from code tests. Let's set up that workflow before merging. I've also got some compatibility tests running over at CiaranOMara/GenomicFeatures.jl, I'd like to add those results to this release as well.

TransGirlCodes commented 4 years ago

Yeah the Compat helper looks cool, I made a mental note to set it up for our genome assembler repository.

CiaranOMara commented 4 years ago

I think this is now good enough. However, the DOCUMENTER_KEY would need to be set up before merging this into master.

CiaranOMara commented 4 years ago

I set the CompatHelper to generate PRs against the master branch with the gitflow workflow in mind. The idea being that development should not block compatibility changes or hotfixes.

CiaranOMara commented 4 years ago

@BenJWard, bump re DOCUMENTER_KEY.

TransGirlCodes commented 4 years ago

@CiaranOMara Ok the documenter key should be set up correctly now. It will only trigger if the PR changes or we merge to master. I'm happy with everything. Do you want me to merge this into master and cut the release? Since it's a patch release I think v1.0.1 can be released on "General", and v2 on "BioJuliaRegistry"?

CiaranOMara commented 4 years ago

@BenJWard, I'm happy for you to merge this into master as well as cut the release, and I think you're spot on about v1 patches going to general.

Also, the documenter key looks good, it was able to generate the PR preview.

BioJulia / GenomicFeatures.jl

release/v1.0.1 #22

Codecov Report