BioJulia / IntervalTrees.jl

A data structure for efficient manipulation of sets of intervals
MIT License
44 stars 17 forks source link

Fix a bug in firstintersection that can lead to missed intersections. #34

Closed dcjones closed 6 years ago

dcjones commented 6 years ago

This is a pretty serious and sneaky bug that can cause missed intersections when doing tree vs tree intersection using the "successive" strategy in very particular circumstances.

Btw, I don't have any permissions for this repo anymore. Was that an intentional decision?

codecov-io commented 6 years ago

Codecov Report

Merging #34 into master will increase coverage by 0.27%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   93.01%   93.28%   +0.27%     
==========================================
  Files           3        3              
  Lines         787      789       +2     
==========================================
+ Hits          732      736       +4     
+ Misses         55       53       -2
Impacted Files Coverage Δ
src/IntervalTrees.jl 94.65% <100%> (+0.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c21c73...d661600. Read the comment docs.

bicycle1885 commented 6 years ago

Thank you!

I thought you must be an owner of the BioJulia org. I'm not sure why you were not, but I've just made you an owner. @Ward9250, I believe it's fine, isn't it?

dcjones commented 6 years ago

Thanks!

bicycle1885 commented 6 years ago

I think this need to be released soon. Will you do? If you won't, I will do that if no objections.

TransGirlCodes commented 6 years ago

That's totally fine, Dan and Richard were removed from owner, under Richard's advisement, after a substantial period of inactivity, as inactive users with high permission levels can be a security risk. It was discussed on the Gitter at the time, and prompted me to write the on-boarding and off-boarding guidelines in contributing docs - in particular that there are no barriers to being reinstated, academia and life is hectic, and so it is perfectly reasonable to expect members to come, go, and even come again.

bicycle1885 commented 6 years ago

@Ward9250 Okay, it makes sense.

@dcjones Thank you for releasing it.