Closed cjprybol closed 1 year ago
Rad, thanks for all the help with this package.!
Glad to help, thanks for the assistance with the PRs!
To be clear - it looks like the dependency you referenced at the beginning has been merged - is there a release of BioSequences that includes it yet? Once it is, this PR should include an update to the
[compat]
section ofProject.toml
.
I don't see a new release yet but happy to update the compat once one is available
@jakobnissen is there something holding back a release of BioSequences with https://github.com/BioJulia/BioSequences.jl/pull/271 ? I'm happy to do it, but wanted to double check.
Nope, please do cut a release. Also nice to get the other changes since last release. They're all bugfixes, so it can be a patch release, 3.1.3.
https://github.com/JuliaRegistries/General/pull/79281
@cjprybol Once that gets merged, I think bump the compat entry, which should also re-run the tests, and then I think it will be good to go
Patch coverage: 100.00
% and project coverage change: +0.23
:tada:
Comparison is base (
f7a1328
) 87.43% compared to head (7febcd0
) 87.67%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for finishing this off @SabrinaJaye, and thanks for the helpful reviews @kescobo!
Fixes https://github.com/BioJulia/Kmers.jl/issues/33 but depends on https://github.com/BioJulia/BioSequences.jl/pull/271 in order to pass all tests