search

BioJulia / Libz.jl

Fast, flexible zlib bindings.
Other
27 stars 17 forks source link

Update REQUIRE compat version #44

Closed musm closed 7 years ago

musm commented 7 years ago

I don't want to spend an hour trying to figure out the minimum compat version, but this version will be sufficient

tkelman commented 7 years ago

It takes 15 seconds. This is correct for take!. https://github.com/JuliaLang/Compat.jl/commit/3541c2df0ccf918b97c5d8b5dadd5aa9b1e3f890

musm commented 7 years ago

The real question is how did the tests pass without this correct compat version...

tkelman commented 7 years ago

Because minimum version requirements are just that, minimums. If you don't have any upper bounds / pinnings in effect (and Travis generally won't unless some dependency packages have), then you'll get the latest version. But if you selectively update individual packages without updating their dependencies, or apply pinnings / upper bounds, you can get non-latest copies so that's when getting minimum versions right matters.

TransGirlCodes commented 7 years ago

Ok, I'll have to apply this to the release retroactively