search

BioKIC / NEON-Biorepository

Development base for the NEON Biorepository Data Portal host by BioKIC - Arizona State University (https://biorepo.neonscience.org)
GNU General Public License v2.0
2 stars 1 forks source link

Cannot make edits when a record has multiple otherCatalogNumbers #104

Closed mandrewj closed 2 years ago

mandrewj commented 3 years ago

Describe the bug When an occurrence record has multiple otherCatalogNumbers (e.g. a NEON sampleID and a NEON barcode which is almost ubiquitous across all samples) they are stored in a different table and not concatenated into the otherCatalogNumber field in the occurrence editor.

When collection managers need to make edits to the otherCatalogNumbers (such as change the barcode or the sampleID - which happens most often from requests via ServiceNow) we cannot access them via the occurence editor.

Sometimes one of the otherCatalogNumbers shows up and sometimes none do - this seems to maybe be correlated with IGSN assignment, but either way I have never seen both displayed at the same time within a record.

The public view works very well, it is just the editing that is an issue.

To Reproduce Steps to reproduce the behavior: Go here: https://biorepo.neonscience.org/portal/collections/editor/occurrenceeditor.php?occid=789424 or here: https://biorepo.neonscience.org/portal/collections/editor/occurrenceeditor.php?occid=870754

kyule commented 3 years ago

Related to editing other catalog numbers: when a sampleID is corrected, often both the new and old ones show up as other catalog numbers. While tracking both may be a good idea, it does cause some problems when IDs are switched (ie. now the same sampleID is associated with multiple samples) and when the link out to the sample viewer directs to the old, incorrect sampleID (eg. https://biorepo.neonscience.org/portal/collections/individual/index.php?occid=321065&clid=0)

egbot commented 2 years ago

Issue resolved by fully integrating omoccuridentifiers table into occurrence editor: https://github.com/BioKIC/NEON-Biorepository/commit/7b8e991c8077e82374e558d05eef589a8d14bb65 https://github.com/BioKIC/NEON-Biorepository/commit/0306dc082a53e29b73abf3ee4beee46c6c59ea8a https://github.com/BioKIC/NEON-Biorepository/commit/ae09c407bd8fa04e110126d8436b9ca304da3331

Also included the completion of the following:

1) Push the new occurrence editor code to production portal. 2) Deleted all sampleIDs and SampleCodes from otherCatalogNumbers field within omoccurrence table. 3) Re-populated sampleID and sampleCode values stored within additional identifier table (omoccuridentifier), in order to ensure they are correct. 4) Adjusted sample manifest code so that it auto-corrects sampleID and sampleCode values stored within additional identifier table whenever the values are updated within the manifest.