egbot
commented
1 year ago Issue resolved: https://github.com/BioKIC/NEON-Biorepository/commit/dd910c88b740ce427e82120e7bbd58fec073f6f9 https://github.com/BioKIC/NEON-Biorepository/commit/c73e0d74635db500ace472b6034c55982b66ca4e
Current actions when harvesting/reharvesting determinations:
- New determination added, with change to current determination: "Curatorial Check" message added to error log
- New determination added, without change to current determination: no message
- New record created where manifest determination differs from new determination via API: manifest ID is not include within the determination history (as per Oct 2022 conversion, manifest IDs are only added if they are the isCurrent ID), but a "Curatorial Check" message is added assuming ID on specimen label needs to be checked
- If record is reharvested, an existing "Curatorial Check" message is preserved until curator reviews and manually removed/reset message
See the pinned beetle NEON.BET.D19.001191 found on this shipment: https://biorepo.neonscience.org/portal/neon/shipment/manifestviewer.php?shipmentPK=2700
This is a good example of the type of issues we run into. The original manifest was incorrect (because the main NEON data are incorrect) so the manifest was edited and a note was left saying what species this is. If you look at the occurrence, the manifest ID is placed in the determination history but the active ID is a different species.
There is no curatorial check error and no flag for me to find this - I just happened across it while doing another data edit.
It seems like the harvesting error step needs to be reconfigured in the updated harvesting code