BioKIC / NEON-Biorepository

Development base for the NEON Biorepository Data Portal host by BioKIC - Arizona State University (https://biorepo.neonscience.org)
GNU General Public License v2.0
2 stars 1 forks source link

Several problems with Manifest that have a large number #518

Closed egbot closed 3 months ago

egbot commented 4 months ago

Several issues include:

Possible solutions:

sunray1 commented 4 months ago

^^ yes, it's quite easy to add pagination with the current library. Can be reduced to however many number of records we'd like. That being said since it's js, I think all those records would still be loaded up front and im not sure if that would speed up loading times.

egbot commented 4 months ago

We discussed this issue within the 2024-08-1 biorepo IT meeting and decided that adding pagination or creating multiple sub-manifests would create restrictions and issues with samples check-in process. It was decided that load tests were need to determine which processes of loading manifests were most restrictive.

egbot commented 4 months ago

Load testing update:

When loading manifest with 5,716 records:

image

Load tests with the JS table sort libraries deactivated rendered results 3-14 times faster. Manifest with > 10,000 records often timed out with JS library activated, but rendered result within 15-20 seconds when deactivated. Specific test results displayed below.

Shipment #888

Shipment #899

Shipment #2392

Shipment #2032

egbot commented 4 months ago

Load profile viewing manifest #2032 (>14K records) with table sort feature turned off.
image

egbot commented 4 months ago

I propose that we add a checkbox or radio buttons that turns on/off the table sort feature. The sort option can be turned on by default, but if the manifest has > 3-5K records, the sort option should be turned off on first load, with the user having the option to reload the manifest with the sort option selected.

An other option should be to refactor the sort option to take place server-side. The downside would be that the page would have to be reloaded anytime a column was sorted, but the pages would load fast.

egbot commented 3 months ago

Issue partially resolved with: https://github.com/BioKIC/NEON-Biorepository/commit/8bbad22c5a984c4bc3cf7933bded8144d9a875c0

egbot commented 3 months ago

Working with Greg to increase POST variable limit within PHP config file