BioKIC / Symbiota

The Symbiota Virtual Flora/Fauna project develops on-line tools to aid the generation, exploration and management of biodiversity data (collection specimens, observations, images, checklists, keys, etc.). See also: http://bdj.pensoft.net/articles.php?id=1114 and https://symbiota.org/. For documentation, please visit https://symbiota.org/docs
GNU General Public License v2.0
33 stars 49 forks source link

[3.1] Checklist notes do not allow html formatting #1390

Open MiguelGrande opened 1 month ago

MiguelGrande commented 1 month ago

We commonly add information, including html code and URL links, to the "Habitat" and "Notes" fields of the CCH2 Checklists. With the revision, it appears that when we make an addition or even a change to these, it becomes garbled when saved. E.g., for the Whiting Ranch checklist, an edit in the "Habitat" field to: NATURALIZED (native to central North America), when Saved, becomes garbled.
In the Whiting Ranch Wilderness Park Vascular Plant Checklist (Local Floras), if you click the edit button (pencil) for the third taxon, Yucca gloriosum, you will see the Habitat field reads: "<b>NATURALIZED</b> (native to central North America)". It should read "NATURALIZED (native to central North America)". If you try to change it to this correct html code and Save edits, you will see that you get the garbled text as before. The same is true for the Notes field, where we have put links to iNat and Calflora observations (listing the URLs). Those for this taxon are also garbled. When, we try to correct, the same garbled text appears. E.g., see the Habitat and Notes fields for Hesperoyucca whipplei. They are correct. But, if you try to change them, garbled text seems to appear. In another example, the Palomar College Native and Naturalized Plants checklist (Miscellaneous I.), the criteria we designate, e.g., show Common Names, do not transfer over; one must manually select these. Also, any change we make in the Description yields a "Syntax Error", with html coding for a paragraph being added (even though no html coding or special formatting is used there).

themerekat commented 1 month ago

@MiguelGrande , I can't reproduce this issue. Can you send me a link to the checklist and the taxon to which you're trying to add this note? (feel free to send via email if you don't want the link to be public)

MiguelGrande commented 1 month ago

Katie, Okay, I added an example to this problem. Thanks. -Mike

On Jun 3, 2024, at 2:47 PM, Katie Pearson @.***> wrote:

@MiguelGrande https://github.com/MiguelGrande , I can't reproduce this issue. Can you send me a link to the checklist and the taxon to which you're trying to add this note? (feel free to send via email if you don't want the link to be public)

— Reply to this email directly, view it on GitHub https://github.com/BioKIC/Symbiota/issues/1390#issuecomment-2146182597, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO2PNBUNMKEJ3WVXJ5FSLBLZFTP73AVCNFSM6AAAAABIW5442KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWGE4DENJZG4. You are receiving this because you were mentioned.

Dr. Michael G. Simpson Department of Biology San Diego State University San Diego, CA 92182-4614, U.S.A.

Email: @. @.> Voice: 619-594-8012; Fax: 619-594-5676 American Amphitropical Disjunct Website https://plants.sdsu.edu/AAD Amsinckiinae-Popcorn Flowers Website https://plants.sdsu.edu/amsinckiinae/ Personal Website https://plants.sdsu.edu/simpson/ Plant Systematics Texbook https://www.elsevier.com/books/plant-systematics/simpson/978-0-12-812628-8
SDSU Biodiversity Museum https://biodiversitymuseum.sdsu.edu/ SDSU Herbarium https://herbarium.sdsu.edu/ SDSU Mediterranean Garden https://medgarden.sdsu.edu/

themerekat commented 1 month ago

@MiguelGrande , ah, ok I see the issue! You are adding html-formatted information to the form, which is being reformatted to be "non-harmful" non-html formatting. Allowing html formatting is actually a bit of a security vulnerability, so we have been adding functions that disallow this. Let me check with the programmers to see if there is a way that html formatting can be allowed in a safe way.

MiguelGrande commented 1 month ago

Thanks. I hope so. We have spent many hundreds of person-hours doing these, so hope we can maintain it. -Mike

On Jun 4, 2024, at 6:07 AM, Katie Pearson @.***> wrote:

@MiguelGrande https://github.com/MiguelGrande , ah, ok I see the issue! You are adding html-formatted information to the form, which is being reformatted to be "non-harmful" non-html formatting. Allowing html formatting is actually a bit of a security vulnerability, so we have been adding functions that disallow this. Let me check with the programmers to see if there is a way that html formatting can be allowed in a safe way.

— Reply to this email directly, view it on GitHub https://github.com/BioKIC/Symbiota/issues/1390#issuecomment-2147491796, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO2PNBUDHL6IVCYHXSGUNOTZFW3X5AVCNFSM6AAAAABIW5442KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGQ4TCNZZGY. You are receiving this because you were mentioned.

Dr. Michael G. Simpson Department of Biology San Diego State University San Diego, CA 92182-4614, U.S.A.

Email: @. @.> Voice: 619-594-8012; Fax: 619-594-5676 American Amphitropical Disjunct Website https://plants.sdsu.edu/AAD Amsinckiinae-Popcorn Flowers Website https://plants.sdsu.edu/amsinckiinae/ Personal Website https://plants.sdsu.edu/simpson/ Plant Systematics Texbook https://www.elsevier.com/books/plant-systematics/simpson/978-0-12-812628-8
SDSU Biodiversity Museum https://biodiversitymuseum.sdsu.edu/ SDSU Herbarium https://herbarium.sdsu.edu/ SDSU Mediterranean Garden https://medgarden.sdsu.edu/