The Symbiota Virtual Flora/Fauna project develops on-line tools to aid the generation, exploration and management of biodiversity data (collection specimens, observations, images, checklists, keys, etc.). See also: http://bdj.pensoft.net/articles.php?id=1114 and https://symbiota.org/. For documentation, please visit https://symbiota.org/docs
GNU General Public License v2.0
33
stars
49
forks
source link
[3.1] Minimal header - part 1 (incomplete implementation that defaults as disabled until [3.2] part 2 is done) #1429
This PR begins to implement the minimal header in the following files:
checklists/tools/mappointaid.php
collections/georef/georefclone.php
collections/individual/index.php
collections/map/index.php
collections/tools/mappointaid.php
It partially implements the minimal header in:
checklists/checklistmap.php
checklists/clgmap.php
Also fixes a bug in collections/search/index.php that I found when a user clicks the "advanced search" button from a collection profile page.
But functionality in those is incomplete, and commented-out when necessary.
Because priorities for the implementation of this have changed (and it now no longer needs to be a 3.1 priority) AND because I don't want to have to maintain cumbersome merge conflict resolution on this as 3.2 (or 3.1.x) approaches (like I'm already doing for this PR, and it's been non-trivial), it made sense to split this PR into what I have done currently vs. what I want to implement in the future (see separate part 2 issue here).
This PR is currently set up so that it doesn't affect any pages unless someone goes out of their way to add $SHOULD_USE_MINIMAL_MAP_HEADER = true; in symbini.php.
QA Notes
This is live in dev001.symbiota.org
Pull Request Checklist:
Pre-Approval
[x] There is a description section in the pull request that details what the proposed changes do. It can be very brief if need be, but it ought to exist.
[ ] Hotfixes should be branched off of the master branch and squash and merged back into the master branch.
N/A
[x] Features and backlog bugs should be merged into the Development branch, NOTmaster
[ ] All new text is preferably internationalized (i.e., no end-user-visible text is hard-coded on the PHP pages), and the spreadsheet tracking internationalizations has been updated either with a new row or with checkmarks to existing rows.
N/A
[x] There are no linter errors
[x] New features have responsive design (i.e., look aesthetically pleasing both full screen and with small or mobile screens)
I had to mess with the z-index on some pages when the screen is really small and switched to hamburger menu mode.
[x] If this PR makes any changes that would require additional configuration of any Symbiota portals outside of the files tracked in this repository, make sure that those changes are detailed in this document.
Add to the 3.2 section of the document.
Post-Approval
[ ] It is the code author's responsibility to merge their own pull request after it has been approved
[ ] If this PR represents a merge into the Development branch, remember to use the squash & merge option
[ ] If this PR represents a merge from the Development branch into the master branch, remember to use the merge option
[ ] If this PR represents a hotfix into the master branch, a subsequent PR from master into Development should be made merge option (i.e., no squash).
[ ] If the dev team has agreed that this PR represents the last PR going into the Development branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock the Development branch to prevent accidental merges while QA takes place. Follow the release protocol here.
[ ] Don't forget to delete your feature branch upon merge. Ignore this step as required.
Description
This PR begins to implement the minimal header in the following files:
It partially implements the minimal header in:
But functionality in those is incomplete, and commented-out when necessary.
Because priorities for the implementation of this have changed (and it now no longer needs to be a 3.1 priority) AND because I don't want to have to maintain cumbersome merge conflict resolution on this as 3.2 (or 3.1.x) approaches (like I'm already doing for this PR, and it's been non-trivial), it made sense to split this PR into what I have done currently vs. what I want to implement in the future (see separate part 2 issue here).
This PR is currently set up so that it doesn't affect any pages unless someone goes out of their way to add
$SHOULD_USE_MINIMAL_MAP_HEADER = true;in symbini.php.QA Notes
This is live in dev001.symbiota.org
Pull Request Checklist:
Pre-Approval
masterbranch and squash and merged back into themasterbranch.Developmentbranch, NOTmasterPost-Approval
Developmentbranch, remember to use the squash & merge optionDevelopmentbranch into the master branch, remember to use the merge optionmasterbranch, a subsequent PR frommasterintoDevelopmentshould be made merge option (i.e., no squash).Developmentbranch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock theDevelopmentbranch to prevent accidental merges while QA takes place. Follow the release protocol here.Thanks for contributing and keeping it clean!