search

BioKIC / Symbiota

The Symbiota Virtual Flora/Fauna project develops on-line tools to aid the generation, exploration and management of biodiversity data (collection specimens, observations, images, checklists, keys, etc.). See also: http://bdj.pensoft.net/articles.php?id=1114 and https://symbiota.org/. For documentation, please visit https://symbiota.org/docs
GNU General Public License v2.0
38 stars 51 forks source link

Photographer uid versus photographer override problems in Image Search #602

Open themerekat opened 1 year ago

themerekat commented 1 year ago

If the photographer is provided through a photographer override, rather than through photographeruid, the name does not show up in the Image Search results. When a photographeruid exists (even if an override also exists), that name is shown instead of the photographer override.

For an example, search in the bryophyte portal for the taxon name Pseudomalia webbiana in the Image Search. The one field image there has a photographer override, but Blanka's name shows up.

Related issue: when you search for images taken by Blanka, this image shows up in the results because her photographeruid is still associated with the record.

themerekat commented 1 year ago

Issue appears to be in /imagelib/search.php lines 308-316

egbot commented 1 year ago

This is more of a problem with the data. There are 2 photographers defined, Blanka and Des Calleghan. There should only be one photographer defined. For reference, I've included a link to the specific image below, along with a screenshot. However, the user interface is confusing and can be clarified, which I can improve. The photographer "override" is a misnomer. It's more to accommodate non-registered photographers/users, and is for display only. Only registered users are searchable. Verbatim text of non-registered users is uncontrolled and difficult to index within a search. One needs to register a user if they want them to be searchable.

image https://bryophyteportal.org/portal/imagelib/imgdetails.php?imgid=2476771

Only registered users are displayed on this page, and are searchable: https://bryophyteportal.org/portal/imagelib/contributors.php

themerekat commented 1 year ago

Perfect, yes I think the user interface is mainly the problem (the fact that it defaults to the uploader even when an override is added). I wonder what a good solution for this would be.

themerekat commented 1 year ago

(FWIW, I did suggest to Blanka that the photographer should actually get an account in the Bryophyte Portal!)

egbot commented 1 year ago

If they want their images to be indexed and searchable, photographers need to create an account. The problem is with photographers that are no longer living. For now, we can create an account for these folks, and later we can integrate the agents table.