BioLockJ-Dev-Team / sheepdog_testing_suite

Test suite for BioLockJ development team.
3 stars 8 forks source link

inherited properties need to inherit description etc #318

Closed IvoryC closed 3 years ago

IvoryC commented 3 years ago

In the output of the command

biolockj-api propType --property genMod.scriptPath --module biolockj.module.diy.ForEachFile

file path

So, the api seems to know that property genMod.scriptPath is of type file path.

But in the output of the command

biolockj-api moduleInfo

here is a segment of the properties for the ForEachFile module:

... { "property": "docker.verifyImage", "type": "boolean", "description": "In check dependencies, run a test to verify the docker image." }, {"property": "genMod.launcher"}, {"property": "genMod.param"}, {"property": "genMod.resources"}, {"property": "genMod.scriptPath"}, { "property": "script.defaultHeader", "description": "Store default script header for MAIN script and locally run WORKER scripts.", "default": "#!/bin/bash", "type": "string" }, ...

Here the genMod.scriptPath property has no type or description.

IvoryC commented 3 years ago

This was a little mis-diagnosed. It has been fixed, and merged with pulled request: Shiny gui #80 see commit "Use the module to get the correct module property info."