search

BioLockJ-Dev-Team / sheepdog_testing_suite

Test suite for BioLockJ development team.
3 stars 8 forks source link

docker config options are too verbose #335

Open IvoryC opened 11 months ago

IvoryC commented 11 months ago

When running a pipeline of all GenMod modules, the user has to specify ModuleName1.imageOwner=me ModuleName1.imageName=tidyr ModuleName1.imageVersion=v2 ... ModuleName2.imageOwner=me ModuleName2.imageName=tidyr ModuleName2.imageVersion=v2

IvoryC commented 11 months ago

The problem is that specifying the overall docker.imageOnwer property affects not only the module containers but also the main container that BioLockJ itself is run in.

Maybe specifying GenMod.imageOwner would work? ...need to test that. Maybe add that as a feature if it does not exist.

A more effective route would be to set the main docker container for BioLockJ main, and make that different property from the docker.imageOwner etc that is used for modules. But since those two systems currently use the same property, we would have to comb through to separate out all usages.