BioMemPhys-FAU / domhmm

Open source package to identify nano- and microdomains in Molecular Dynamics simulations of bio-membranes.
https://www.biomemphys.nat.fau.de
GNU General Public License v2.0
1 stars 0 forks source link

LeafletFinder Removal in MDAnalysis 3.0.0 #25

Open m-a-r-i-u-s opened 4 months ago

m-a-r-i-u-s commented 4 months ago

Is your feature request related to a problem?

The LeafletFinder function will be removed in MDAnalysis 3.0.0 (see https://github.com/MDAnalysis/mdanalysis/issues/4544#issue-2216069497)

Describe the solution you'd like

DomHMM's core functionality is not, and should be not, leaflet identification. The flipping of phospholipids happens only rarely on MD relevant time scales. I would suggest that users should provide their own leaflet assignments by default. However, we have the code for automatically leaflet assignment already at hand. We could therefore offer this as an option that must be explicitly triggered by the user.

I would suggest this workflow

yusuferentunc commented 4 months ago

In the MDAnalysis issue, they redirect users to use a MDAKits implementation for LeafletFinder https://lipyds.readthedocs.io/en/latest/leafletfinder.html

However, that kit's implementation doesn't seem robust for current time