BioMotionLab / TUX

A framework for experiments in Unity and VR
https://biomotionlab.github.io/TUX/
Other
29 stars 4 forks source link

Custom Design File Location and File Validation #55

Closed DerMilchmann closed 2 years ago

DerMilchmann commented 2 years ago

Output files either take a full path or they are relative to the MyDocuments folder. The Design File Location can also take a full path or is relative to the root folder of the Application, which is inconsistent in my opinion. Also unlike output files, the Custom Design Input Field doesnt have a Validator and it crashes instead of throwing a nice error popup.

Changes: UI

Scripts

AdamBebko commented 2 years ago

Thanks. This looks great. I will try to include it in the next version

AdamBebko commented 2 years ago

Ok so I'm including it, In the future, it would help to try to split up your pull requests a bit more. So like the UI changes with the padding should probably be separate from the validation. This makes it easier to revert and debug if there are any breaking changes.

DerMilchmann commented 2 years ago

I am thrilled to hear that this will make it in the next version. Thanks for the feedback :)

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: