search

BioPP / grapes

(Greetings_here_is_yet_another) Rate of Adaptive Protein Evolution Software
GNU General Public License v3.0
9 stars 1 forks source link

Problems with installing grapes in macOS #3

Closed izabelcavassim closed 4 years ago

izabelcavassim commented 4 years ago

Hi, I have tried to install this software in macOs with the required dependencies, and this is what I get:

/grapes-master/grapes/Grapes.cpp:8:10: fatal error: 'values.h' file not found

By googling it I can see that values.h is deprecated in C and one should use limits.h instead. When I comment out //#include from the Grapes.cpp file I get the following message:

/grapes-master/grapes/Grapes.cpp:2118:18: error: use of undeclared identifier 'DBL_MAX'

Then I decide to define the 'DBL_MAX' within the header as follow:

define DBL_MAX 1.79769e+308

Everything compiles smoothly!!

I just wanna know if making these modifications will cause any issue to the stability of the software. I am not very familiar with c++, so I can't tell. Thanks!!

jydu commented 4 years ago

Hi Izabel,

I had the impression I had fixed that already :s the modern way of coding this is to replace DBL_MAX by std::numeric_limits::max() (indeed defined in limits.h). But your solution also works! I have updated the code, also including some compatibility update with the development version of Bio++.

Cheers,

Julien.