BioPhoton / angular-formatter-parser

Angular Formatter Parser - The AngularJS Port - Easy to implement and elegant to use it also provides the possibility to register custom transform functions.

https://github.com/BioPhoton/angular-formatter-parser

MIT License

50 stars 7 forks source link

fix for the implementation in ion-inputs. #3

Closed lhpaul closed 7 years ago

lhpaul commented 7 years ago

Now the directive is loaded after ngAfterViewInit event instead of ngOnInit

lhpaul commented 7 years ago

I cant find where the problem with SyncTestZoneSpec is originated

BioPhoton commented 7 years ago

Hy, sry!! I'm in the process of changing the testing a bit. I will fix this!!!

And BIIIIIGGGG THX for the PR.

lhpaul commented 7 years ago

1 Thanks to you!

BioPhoton commented 7 years ago

Hi again. I'm finished with the test stuff...

Could you do me a favour:

pull my latest changes
npm run build
copy dist into ./examples/angular4/node_modules/angular-formatter-parser
cd into ./examples/angular4
run ng serve
test if you can use the inputs

Best Michael

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 95.276% when pulling 67749c175074cebf84b8c20beb8cebf4fa92532a on lhpaul:master into d89e01725b529fdb9da3b5e64907b5d74aede4af on BioPhoton:master.

codecov-io commented 7 years ago

Codecov Report

Merging #3 into master will decrease coverage by 0.45%. The diff coverage is 75%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage    95.5%   95.05%   -0.46%     
==========================================
  Files           8        8              
  Lines         178      182       +4     
  Branches       24       25       +1     
==========================================
+ Hits          170      173       +3     
- Partials        8        9       +1

Impacted Files	Coverage Δ
src/formatter-parser.directive.ts	`94.02% <75%> (-1.21%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d89e017...67749c1. Read the comment docs.

lhpaul commented 7 years ago

Done.

Please check my code because there might be a better solution.

Thxs

BioPhoton commented 7 years ago

Hi @lhpaul , could you please give it a quick try in ionic? If it works i will release it.

Would save me time.

best michael

cmolina commented 7 years ago

Hi! When could we try this feature in a new version? :) We really need this 🔝

BioPhoton commented 7 years ago

Hi @camolin3 i reopened the issue because i got bad outcome in a real inplementation. See #1. I guess it will take some time.