search

BioPhoton / angular-star-rating

Star Rating Angular Component written in typescript, based on css only techniques.
MIT License
217 stars 86 forks source link

Hover effect does not work when hoverEnabled, showHalfStar, readOnly property is set to true. #110

Closed pavandixit93 closed 5 years ago

pavandixit93 commented 5 years ago

I'm submitting a...


[ ] Bug report  
[ ] Feature request

Current behavior

It does not show filled star when we hover on stars for given configuration. It works perfectly when showHalfStars is unchecked and other two fields are checked.

Expected behavior

It should show hoverd effects for this configuration.

Minimal reproduction of the problem with instructions

Environment

https://biophoton.github.io/angular-star-rating/#/property-bindings Please select showHalfStar, showHoverEnabled, readOnly then try to hover on stars present at the top.


Library version: X.Y.Z
Angular version: X.Y.Z


Browser:

- [ ] Chrome (desktop) version XX

As per my obervation, above issue is due to https://github.com/BioPhoton/css-star-rating/blob/90eaa54dab1df72ca8fdfdab7801a5fa4a64312d/dist/scss/_modifiers.scss#L80

pavandixit93 commented 5 years ago

To fix this issue, set hoverEnabled=false when readOnly or disabled state is true.