search

BioPhoton / angular-star-rating

Star Rating Angular Component written in typescript, based on css only techniques.
MIT License
217 stars 86 forks source link

console.log made it into production #122

Closed AlexanderTang closed 2 years ago

AlexanderTang commented 2 years ago

Subject of the issue

Since at least version 5.0.1 (and perhaps earlier) I encounter a bunch of console logs from this dependency. I updated to the currently latest version 5.1.0 and this console.log has not been removed yet. It stems from line 259 in angular-star-rating.mjs:

console.log('useHoverValue: ', useHoverValue);

This should be removed.

Your environment

Steps to reproduce

Simply open a page where the star rating is used.

Expected behaviour

No console logs visible

Actual behaviour

Yes console logs visible

billyjov commented 2 years ago

Hi @AlexanderTang ..I will deploy a new version were all logs are removed. Thanks for pointing this out

billyjov commented 2 years ago

This commit https://github.com/BioPhoton/angular-star-rating/commit/3428421602d1b8089e114504709dd215c3c2fbab fix this behavior and will come with the next version

AlexanderTang commented 2 years ago

Thanks for the quick response and fix! Cheers.