search

BioPhoton / angular-star-rating

Star Rating Angular Component written in typescript, based on css only techniques.
MIT License
217 stars 85 forks source link

~/css-star-rating/dist/scss/star-ratings.scss couldn't be resolved #85

Closed juleskreutzer closed 6 years ago

juleskreutzer commented 6 years ago

I'm submitting a...


[x] Bug report  
[ ] Feature request

Current behavior

Module build failed: Error: Can't resolve 'css-star-rating/dist/scss/star-rating.scss' in ...

Expected behavior

I expect that the file can be resolved

Minimal reproduction of the problem with instructions

Install version 3.0.8 and set it up. It can't find the file ~/css-star-rating/dist/scss/star-rating.scss because the path is invalid. I think it could be solved by pointing to the folder ~/css-star-rating/scss/star-rating.scss

Environment


Library version: 3.0.8
Angular version: 5
maelfosso commented 6 years ago

@juleskreutzer I also had the same problem

  1. Open node_modules/angular-star-rating/assets/scss/star-rating.scss
  2. Change ~css-star-rating/dist/scss/star-rating.scss with "~css-star-rating/scss/star-rating.scss";
  3. You could see that by opening node_modules/css-star-rating. It doesn't have a folder dist
BioPhoton commented 6 years ago

Hi @juleskreutzer thx for this issue! :-)

This is should be fixed in the latest version.

Feel free to reopen this issue if needed.

juleskreutzer commented 6 years ago

Which is 4.0.0-beta3? Because I have this issue on 3.0.8

BioPhoton commented 6 years ago

Yes 4.0.0-beta.3

BioPhoton commented 6 years ago

I changed the selector btw... just that you know.

juleskreutzer commented 6 years ago

Great! I’ll give it a try when I have the time for it.