search

BioPsyk / cleansumstats

Convert GWAS sumstat files into a common format with a common reference for positions, rsids and effect alleles.
https://biopsyk.github.io/metadata/#!/form/cleansumstats
13 stars 2 forks source link

files in out_dbsnp folder have All_20180418 prefix regardless of which dbSNP version is actually used #411

Closed ofrei closed 3 months ago

ofrei commented 6 months ago

From what I remember 20180418 is a timestap that relates to dbSNP v151, but it also appears in file names if we use dbSNP v156 Here is an example where we deployed cleansumstats v1.5.3 using dbSNP v151, and v1.7.0 uses dbSNP v156. The file size of the files in out_dbsnp is different but file names are the same

image image
ofrei commented 6 months ago

That a minor point - I think everything works as expected, just file name is confusing

pappewaio commented 6 months ago

Yes! You are right. I thought I would not change the output names in case it messes with downstream processes. But now when we know that the reference DB works as expected, I should come up with a good naming/versioning scheme.

pappewaio commented 3 months ago

Fixed this. PR #417