search

BioSTEAMDevelopmentGroup / Bioindustrial-Park

BioSTEAM's Premier Repository for Biorefinery Models and Results
MIT License
36 stars 17 forks source link

Consultation about loan in cellulosic_ethanol model #101

Closed zasddsgg closed 4 months ago

zasddsgg commented 4 months ago

In the worksheet Cash flow of the excel file exported by the cellulosic_ethanol model, according to the source code L[:start] = loan = self.finance_fraction*(C_FC[:start]) in https://biosteam.readthedocs.io/en/latest/_modules/biosteam/_tea.html#TEA:~:text=L%5B%3Astart%5D%20%3D%20loan%20%3D %20self.finance_fraction*(C_FC%5B%3Astart%5D), the value of cell F4 should be cell C4 multiplied by finance_fraction, which is 0.4, but it is not in excel, which is unreasonable. While cell F2 and cell F3 are cell C2 and cell C3 multiplied by 0.4, respectively, which is reasonable. For the abnormal value of cell F4, may I ask you is there anything wrong with cell F4?

As shown in the screenshot, F2=C2*0.4, F3=C3*0.4, it is reasonable. But for cell F4, F4 is not C4 times 0.4, which is a little strange. I check TEA excel file of NREL, it is F4=C4*0.4.

The screenshot is as follows: I use BioSTEAM 2.38.3, biorefineries 2.26.2 1

yoelcortes commented 4 months ago

Thanks for posting this issue! It has been fixed since a couple of months ago. I generated the following table using biosteam 2.43.1: image

zasddsgg commented 4 months ago

I got it. Thanks for your help again.