BioSTEAMDevelopmentGroup / Bioindustrial-Park

BioSTEAM's Premier Repository for Biorefinery Models and Results
MIT License
38 stars 17 forks source link

Being able to import lactic acid packages #26

Closed blsymens closed 3 years ago

yalinli2 commented 3 years ago

Hi Bavo,

Thanks for the request! We will update the package to include the lactic acid bio refinery. The error you noted in the email was because updates in biosteam, I’ll update the biorefinery so that it’ll be compatible with the newer biosteam, thank you for the interest in our work!

Yalin

On Sat, May 1, 2021 at 8:50 AM Bavo Symens @.***> wrote:


You can view, comment on, or merge this pull request online at:

https://github.com/BioSTEAMDevelopmentGroup/Bioindustrial-Park/pull/26 Commit Summary

  • Add lactic directory for setup
  • Update lactic string

File Changes

Patch Links:

- https://github.com/BioSTEAMDevelopmentGroup/Bioindustrial-Park/pull/26.patch

https://github.com/BioSTEAMDevelopmentGroup/Bioindustrial-Park/pull/26.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BioSTEAMDevelopmentGroup/Bioindustrial-Park/pull/26, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALV5VLITY7HGPRRDZDBMNUTTLQBJHANCNFSM436LBZCA .

yalinli2 commented 3 years ago

Hi @blsymens, I've updated the lactic acid biorefinery in commit 94bff08. It should work with current biosteam (v2.28.2). Note that @yoelcortes needs to include this biorefinery in the package setup and publish it on PyPI. Thanks!!!

yalinli2 commented 3 years ago

PS, the setup.py should be updated with:

'lactic/*',
'lactic/analyses/*',

To include the different analyses in the paper. Thanks!

Hi @blsymens, I've updated the lactic acid biorefinery in commit 94bff08. It should work with current biosteam (v2.28.2). Note that @yoelcortes needs to include this biorefinery in the package setup and publish it on PyPI. Thanks!!!