BioSTEAMDevelopmentGroup / Bioindustrial-Park

BioSTEAM's Premier Repository for Biorefinery Models and Results
MIT License
37 stars 18 forks source link

More Specific Corn Biorefinery Naming #40

Closed yoelcortes closed 1 year ago

yoelcortes commented 1 year ago

Hi Yalin,

Thanks for updating details in the corn biorefinery! I believe in your recent commits, the name of the corn biorefinery was changed from "Conventional Dry Grind" to "Conventional Dry Milling". I think dry milling is less specific than "conventional dry grind" because germ and fiber is usually separated upstream in a dry-milling process. You can checkout the following publication for details on the many configurations for processing corn:

https://www.mdpi.com/2227-9717/7/9/578

Also the corn biorefinery is based almost entirely on this publication on conventional dry grind:

https://linkinghub.elsevier.com/retrieve/pii/S0926669005000944

By the way, if you are ever unsure about a change/contribution (which are always welcome), feel free to make a pull request first, Thanks!

yoelcortes commented 1 year ago

Thanks so much for adding the references and the updates!

yalinli2 commented 1 year ago

Ah thanks @yoelcortes for noting this! I updated the README accordingly and add the refs https://github.com/BioSTEAMDevelopmentGroup/Bioindustrial-Park/commit/da1c6f7615bf1a8c875520702e07c11a2921e65e. However GH seems to mess up the citation and turn J. R. into 10.xviii, do you know how to fix this (it won't do this if I took out the space between J. and R.)? 🤷‍♂️

yoelcortes commented 1 year ago

@yalinli2, yeah, I have had similar issues when using restructured text. I ended up using markdown instead (which you can combine with html on github). I forgot to reference the issue in commit https://github.com/BioSTEAMDevelopmentGroup/Bioindustrial-Park/commit/feaa2985a932d853e20d281fe9c8f03fc56151b6 but that commit should fix it

yalinli2 commented 1 year ago

Ah I see, thanks!