search

BioSTEAMDevelopmentGroup / Bioindustrial-Park

BioSTEAM's Premier Repository for Biorefinery Models and Results
MIT License
37 stars 18 forks source link

`RIN_splitter` in oilcane biorefinery #50

Closed yalinli2 closed 1 year ago

yalinli2 commented 1 year ago

Hi @yoelcortes , I noticed some weird with the RIN_splitter for the O2 configuration of the oilcane biorefinery, essentially,

>>> from biorefineries import oilcane as oc
>>> oc.load('O2')
>>> oc.sys.diagram()

sys_diagram

You can see that the RIN_splitter in the diagram takes both ethanol and biodiesel and have four outs, but

>>> oc.RIN_splitter.diagram()

RIN_splitter_diagram

Now it only has the ins/outs for biodiesel-related streams. I'm wondering why this would be happening? Also is it intentional that ethanol and biodiesel are using the same RIN_splitter?

BTW, I'm trying to compare results for the WWT work I can now compared to about a month ago, results for some biorefineries are reasonably close, but MESP for the O2 configuration of the oilcane biorefinery is really off, so I'm trying to figure out why... Thanks!!!

yoelcortes commented 1 year ago

Ahh, I introduced a bug for O2 while working on O6. It should be fixed now (only the ethanol should go to the RIN_splitter for O2). I'm going to introduce a long barrage of tests for S1, S2, O1, O2, O3, O4, and their respective agile versions with sorghum pretty soon. These bugs are totally preventable.

yalinli2 commented 1 year ago

wonderful! yep now the MESP looks good, having tests added would be super, thanks @yoelcortes !