Closed zasddsgg closed 8 months ago
@zasddsgg, thanks for posting this bug. Previously the heat exchanger associated with the flash was assuming constant pressure. This has been fixed in the latest commits. Tests has also been added to make sure this doesn't become an issue in the future: https://github.com/BioSTEAMDevelopmentGroup/biosteam/blob/master/tests/test_flash.py
If you use the latest github version, you should get the results you expect.
Thanks!
Hello, when I run the following code,
F1.Hnet
is 1.68e+07, but the duty inF1.results()
is the cooling water, which is -6.09e+06, the two value seem to be so different, could I consult you which value should I use? If I removethermo.mixture.include_excess_energies = True
,F1.Hnet
and duty inF1.results()
become the same. But according tohttps://biosteam.readthedocs.io/en/latest/API/units/compressor.html#:~:text=Simulate%20reversible%20isothermal%20compression%20of%20gaseous%20hydrogen.%20Note%20that%20we%20set%20include_excess_energies%3DTrue%20to%20correctly%20account%20for%20the%20non%2Dideal%20behavior%20of%20hydrogen%20at%20high%20pressures
, It seems appropriate to addthermo.mixture.include_excess_energies = True
.The code is as follows: