Open yalinli2 opened 2 years ago
1) I just gave you access to the repo. Not sure how you were missed. 2) In terms of being public or private, I think Yoel said there was sensitive information in the repo? 3) You may have something to install or update or fix? 4) The package.json in the gitignore is on me I accidentally added it while adding the package-lock.json
Actually, looking more into package-lock.json, it may be a bad idea to remove for the sake of consistency among contributors.
Cool thanks Kevin! For package-lock.json
, is there anyway to install from it (like you reproduce conda environment)?
For the error shown above, I'm new to npm
and not sure how to fix it, which package should I update and to which version? I tried to use the --force
flag but ran into more errors later, I'll just make changes and pray it's fine, and then rely on you/Nidhi to fix the formatting, thanks!
Yalin, I just tweaked the postcss dependencies, it might fix your issues, however I'm not sure how to reproduce your error, so I am not sure.
Thanks @kgukevin ! I think your tweak worked in resolving the dependency issue, but then I ran into another one related to gyp
:
2021-11-24T17_01_43_080Z-debug.log
However, I'll just let it go since I won't be working on it a lot other than updating the text.
For package-lock.json
, keeping it as you suggested make sense, with the only caveat I see being that it will be constantly updated when multiple people are working on it (i.e., your package-lock.json
might not be the same as Nidhi's, but I might be wrong on this)
Thanks!
Feel free to close it if you want, I just want to make sure you see my reply, thanks!
My understanding of package-lock.json is that it records the entire dependency tree for a project. So that when other developers run install, it will install the dependencies in package.json in the exact same manner as detailed in whatever package-lock.json is present - thereby preserving consistency across everyone, instead of allowing npm to create unique dependency trees from package.json on its own.
I'll keeps this open to look into the gyp stuff.
Sounds great about package-lock.json
, thanks!
OK I'm having several problems here:
Not sure if this is my problem with the setting, but do I have writing access to this repo @kgukevin @yoelcortes ? I made some changes and tried to push, but git refused (and docs here said it could be I didn't have the permission)
Also forking is disabled so I couldn't fork as well. Why would we want this repo to be private?
Additionally, I couldn't run it locally, the error screenshot/log are attached
eresolve-report.txt
package.json
is included in.gitignore
? I thought we would want the dependencies info to be up to date, includingpackage-lock.json
in.gitignore
makes sense because that'll be generated locally when runningnpm install
package-lock.json
file?Thanks!