Error raised when setting properties

BioSTEAMDevelopmentGroup / thermosteam

BioSTEAM's Premier Thermodynamic Engine

Other

57 stars 12 forks source link

Error raised when setting properties #12

Closed yalinli2 closed 4 years ago

yalinli2 commented 4 years ago

Description I ran into errors when trying to set some properties of a chemical, for example:

import thermosteam as tmo
HMF = tmo.Chemical('HMF')
HMF.Tm = 564.65

In addition to Tb, the same error will be raised for MW, Tm, Tt, Tc, Pt, Pc, and Vc. I don't think these properties are phase/T/P dependent?

Note I think this error is new, I didn't run into this error when using thermosteam v0.12.17

Environment OS: macOS Catalina 10.15.4 thermosteam: v0.13.2

Thanks!

yoelcortes commented 4 years ago

ahh, thanks for updating and testing! There are some new algorithms to update all places where these constants are used. I'll take care of these bugs and let you know.

yoelcortes commented 4 years ago

Ok, bug is fixed (pip install 0.13.6). There are a couple of changes I'll announce a little later. But I think you might figured some of these out already jaja

yalinli2 commented 4 years ago

Thanks for fixing the bug, I upgraded thermosteam to v0.13.3, but another weird thing happened (seemed like chems.HMF.Tb = 564.65 did nothing):

I suspect I wasn't using it correctly, so I'll wait for your announcement! Thanks!

yoelcortes commented 4 years ago

No no, you're right, this is a bug. Just got it fixed in v0.13.6 Hopefully there are not too many bugs now :)

yalinli2 commented 4 years ago

Yep it runs well now!