search

BioSTEAMDevelopmentGroup / thermosteam

BioSTEAM's Premier Thermodynamic Engine
Other
58 stars 12 forks source link

Very large download size of the git repo #23

Closed fwitte closed 3 years ago

fwitte commented 3 years ago

Cloning the repo took quite a while as some files in the git history seem to be very large (total repo size > 1.5 GB, which seems excessive to me). This is not part of the JOSS paper review, but I think, it could be a good idea, to see what one can do about this. Unfortunately, I cannot help you here as I have no experience on this topic, other than that history manipulation usually is considered bad. Basically, just wanted to let you know. Best regards Francesco

yoelcortes commented 3 years ago

Hi Francesco, thanks for noting this. Yes! The repo is huge mostly because, historically, thermosteam incorporated all the data from thermo due to some problems with simply importing the data from thermo. Now all the data is imported from chemicals, a package that exposes just the databanks and functions for better code-reuse.

I am planning to remove the history before August 2020, but want to do so after the review (just in case reviewers would like to see the commits).

Edit: I'll keep this issue open until I remove old history.

Thanks!

yoelcortes commented 3 years ago

Hi Francesco, I found and easy solution on the user-side to clone the repository within seconds and added a note on it in the "README" file and the documentation (https://thermosteam.readthedocs.io/en/latest/Installation.html). The idea is just to clone the last 100 or so commits using "git clone --depth [depth] [url]". I'll go ahead an close this issue, but let me know if you have any questions!

Thanks,

fwitte commented 3 years ago

Hi Yoel, nice to know, thank you!