Minor issues on Chemical and README

yalinli2 commented 3 years ago

Some minor things I found that might be good to fix:

Should here be new._locked_state = self._locked_state instead?https://github.com/BioSTEAMDevelopmentGroup/thermosteam/blob/9a299a6654766a99d9c21e0b88e05130498d5594/thermosteam/_chemical.py#L699
The shield badge for build (Travis CI) hasn't been updated for months, maybe ask Travis for more credits, remove it, or replace with AppVeyor/GitHub one?
I just realized the other day that if you use the depth flag in cloning, by default it wouldn't include any other branches unless --no-single-branch flag is given, so might be good to add in the README

Thanks!

yoelcortes commented 3 years ago

Hi Yalin,

Thanks for posting these! I'll take care of all these, hopefully within a couple of days. I really do need to get github workflow back working again.

yalinli2 commented 3 years ago

Thanks Yoel for getting these done so quickly!

BioSTEAMDevelopmentGroup / thermosteam