search

BioSTEAMDevelopmentGroup / thermosteam

BioSTEAM's Premier Thermodynamic Engine
Other
57 stars 12 forks source link

Add utf-8 encoding setting in setup.py #42

Closed yalinli2 closed 3 years ago

yalinli2 commented 3 years ago

Hi @yoelcortes, we were helping @GaYeongKim installing qsdsan and she ran into this error:

Picture1

In case that the error message is hard to read, it's about the installation of thermosteam, where this error appeared: UnicodeDecodeError: 'cp949' codec can't decode byte 0xe2 in position 3426: illegal multibyte sequence

After research Ga-Yeong found one way to fix it (and potential other users who don't use English as the primary language in their OS) is to add the encoding system in setup.py, essentially change this:

https://github.com/BioSTEAMDevelopmentGroup/thermosteam/blob/e9cd2ad0715daa71489c50bee021784de1691da8/setup.py#L16

to this:

long_description=open('README.rst', encoding='utf-8').read(),

Can you update this in the setup.py for thermosteam (not sure if you want to do it for biosteam as well)? Thanks!

PS, the users can also fix this by updating their system setting, but I feel updating thermosteam will make it easier for the users.

yoelcortes commented 3 years ago

Thanks Yalin! I believe the problem has to do with the paper reference in the readme (my name has funny letters). I'll also remove the accents and tildes from it.

I will release another biosteam/thermosteam version sometime this week with the updated setup.py and readme.

yalinli2 commented 3 years ago

Yes I think so, maybe one day when I’m unhappy I’ll put my Chinese name on QSDsan and wreak havoc for everyone haha, thanks Yoel!

On Aug 30, 2021, at 8:31 PM, Yoel @.***> wrote:

Thanks Yalin! I believe the problem has to do with the paper reference in the readme (my name has funny letters). I'll also remove the accents and tildes from it.

I will release another biosteam/thermosteam version sometime this week with the updated setup.py and readme.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BioSTEAMDevelopmentGroup/thermosteam/issues/42#issuecomment-908824849, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALV5VLLVOSHQUJK36FA6GWDT7QWIBANCNFSM5DC5VUAQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

yoelcortes commented 3 years ago

Fixed in the latest BioSTEAM version (2.31.7)! Thanks for reporting the issue!