`refresh_constants` bug

BioSTEAMDevelopmentGroup / thermosteam

BioSTEAM's Premier Thermodynamic Engine

Other

57 stars 12 forks source link

Closed yalinli2 closed 2 years ago

yalinli2 commented 2 years ago

Describe the bug Looks like the refresh_constants method is not working for Chemicals

To Reproduce

import thermosteam as tmo
chems = tmo.Chemicals([tmo.Chemical('H2O'), tmo.Chemical('Ethanol')])
chems.compile()
chems.refresh_constants()

Actual behavior Screen Shot 2021-10-05 at 10 48 00 AM

Version

yalinli2 commented 2 years ago

I think I fixed this in 54d3c8b70f6579df286b5f8f918f25a4d908a740, feel free to close this if it's good, but let me know if there are other concerns!

yoelcortes commented 2 years ago

Thanks for taking care of this! I think this covers all constants put in arrays.