search

BioSTEAMDevelopmentGroup / thermosteam

BioSTEAM's Premier Thermodynamic Engine
Other
57 stars 12 forks source link

Latest numba version does not work with latest numpy version #47

Closed fwitte closed 2 years ago

fwitte commented 2 years ago

Describe the bug numba requires numpy<=1.21 (ImportError: Numba needs NumPy 1.21 or less).

To Reproduce Install latest version of thermosteam via pip in a fresh python 3.8 environment.

Additional context Suggest to limit numpy version (see respective PR). I however wonder, why this dependency is not dealt with on the numba side.

yoelcortes commented 2 years ago

Yeah, I found that numba still works with numpy>=1.21, but had to force install numba first before installing biosteam. But best to play be safe not force install anything. Thanks for the pull request!