Thermosteam is no long Python 3.8-compatible

BioSTEAMDevelopmentGroup / thermosteam

BioSTEAM's Premier Thermodynamic Engine

Other

58 stars 12 forks source link

Closed yalinli2 closed 1 year ago

yalinli2 commented 1 year ago

Hi @yoelcortes , I think you accidentally introduced a line that's not Python 3.8-compatible, looking through the commit history and the errors from GHA, I think it's in https://github.com/BioSTEAMDevelopmentGroup/thermosteam/commit/3aeb50ad85600348d970edfe0a8a8eaf7c13ecdb (thermosteam/_chemicals.py probably), can you update it or let people know if you are not planning to support Python 3.8? Thanks!

yalinli2 commented 1 year ago

Just a note that it's frozenset[str] that triggers it, works for 3.9 but not 3.8

yoelcortes commented 1 year ago

OK! I'll make an issue that 3.8 is no longer supported. Thanks!