search

BioSTEAMDevelopmentGroup / thermosteam

BioSTEAM's Premier Thermodynamic Engine
Other
57 stars 12 forks source link

Include thermosteam as part of biosteam #9

Closed wigging closed 4 years ago

wigging commented 4 years ago

Is there a reason why thermosteam is separate from biosteam? Would it make more sense for thermosteam to be a submodule or as a subpackage of biosteam?

yoelcortes commented 4 years ago

Thermosteam is just so independently large, that it makes more sense to have it as a separate package. It also makes things easier to update and manage from the developer side. I am taking some inspiration from Julia packages like "Flux" for machine learning that import from "MLBase". Julia has done a really good job on code reuse, jaja

But just because it is an independent package, doesn't mean we need to keep importing it separately. It would be possible to make the following work:

>>> # Import anything from thermosteam through biosteam
>>> from biosteam import Stream, Chemical, Chemicals, Thermo, settings, MultiStream

I just added this feature in last github update, I'll update PyPI and the docs in a couple of days to replace things like: "from thermosteam import Stream" to "from biosteam import Stream".