search

BioSchemas / specifications

Issue tracker, technical wiki, and example markup
https://bioschemas.org
54 stars 52 forks source link

units for biosample samplingAge #589

Open cmdoret opened 2 years ago

cmdoret commented 2 years ago

Hello and thanks for the great resource ! Currently the samplingAge property of BioSample has range schema:Integer. I assume the value is implicitely meant to be in years, which works for some species.

In many other species (flies, mice), the age is measured using a different unit. I think the unit should also be reflected in the property if needed. Would it be make sense to add schema:QuantitativeValue to the range of samplingAge so that a unit may be specified along with the value ?

gtsueng commented 2 years ago

This makes sense to me. The pending property suggestedAge illustrates that QuantitativeValues is already being used as an expected value for age-related properties, so it's a reasonable suggestion.

Something like:

"samplingAge": {
  "@type": "schema:QuantitativeValue",
  "unitText": "hour",
  "value": "48"
}

or 


"samplingAge": {
  "@type": "schema:QuantitativeValue",
  "unitCode": {"@id": "QUDT:h"},
  "value": "48"
}