BioSchemas / specifications

Issue tracker, technical wiki, and example markup
https://bioschemas.org
51 stars 50 forks source link

Update GitHub actions #625

Open ljgarcia opened 1 year ago

ljgarcia commented 1 year ago

Hi @sahar-frikha After processing the first PR coming from the GitHub actions, if have noticed the following

Redirection looks like

redirect_from: '- "/specifications/Dataset/"

  - "/specifications/Dataset"

  - "/profiles/Dataset/"

  - "/profiles/Dataset"

  - "/devSpecs/Dataset/specification/"

  - "/devSpecs/Dataset/specification"

  - "/devSpecs/Dataset/"

  - "/devSpecs/Dataset"

  - "/specifications/drafts/Dataset/"

  - "/specifications/drafts/Dataset"'

But it should be like

redirect_from:
- "/specifications/Dataset/"
- "/specifications/Dataset"
- "/profiles/Dataset/"
- "/profiles/Dataset"
- "/devSpecs/Dataset/specification/"
- "/devSpecs/Dataset/specification"
- "/devSpecs/Dataset/"
- "/devSpecs/Dataset"
- "/specifications/drafts/Dataset/"
- "/specifications/drafts/Dataset"
ljgarcia commented 1 year ago

Hi @albangaignard all issues sorted out except for the quotation marks for the redirection, please see above. Thanks

ljgarcia commented 1 year ago

Hi @albangaignard one new issue came about GitHub Actions

I got an error that I easily fix but could be an indicative of something on the DDE or Actions side (@gtsueng had a look on the DDE side and she has confirmed that no dates are created there)

  Liquid Exception: Invalid Date: '"202346T165753"' is not a valid datetime. in /home/ubuntu/workspace/bioschemas.github.io/_layouts/profiles.html
             ERROR: YOUR SITE COULD NOT BE BUILT:
                    ------------------------------------
                    Invalid Date: '"202346T165753"' is not a valid datetime.
                    ------------------------------------------------
      Jekyll 4.3.1   Please append `--trace` to the `serve` command
                     for any additional information or backtrace.
                    ------------------------------------------------
albangaignard commented 1 year ago

I found the quotes in this file : https://github.com/BioSchemas/bioschemas.github.io/blob/master/_data/metadata_mapping.csv . @ljgarcia @gtsueng do you know how it is generated ?