BioSchemas / specifications

Issue tracker, technical wiki, and example markup
https://bioschemas.org
51 stars 50 forks source link

Update MolecularEntity profile wrt identification options #639

Open ljgarcia opened 1 year ago

ljgarcia commented 1 year ago

All minimum properties from the released version https://bioschemas.org/profiles/MolecularEntity/0.5-RELEASE (identifier, name, url) have been removed (name and url) or moved to optional (identifier), changes reflected in the draft version 0.6 https://bioschemas.org/profiles/MolecularEntity/0.6-DRAFT

However, the changelog for DRAFT 0.6 does not coincide with the actual changes:

It is necessary to create a DRAFT 0.7 with a more accurate changelog. Please follow the tutorial https://bioschemas.org/tutorials/dde/update_profile in case of doubts on how to update a profile. Some of the expected changes in the changelog and actual changes in the profile are:

ljgarcia commented 1 year ago

Hi @egonw gentle reminder. Also please have a look at https://github.com/BioSchemas/specifications/issues/583 and let us know if the property hierarchy there makes sense to you. Thanks

gtsueng commented 1 year ago

I just wanted to note that even if we decided to nest the properties, the Bioschemas site doesn't actually have pages for individual properties, so there's nowhere this would be displayed until the classes (and properties) are taken up by schema.org (where such a hierarchy) would be shown.

ljgarcia commented 1 year ago

Suggestion: Make identifier minimum and recommend the use of PropertyValue as range so value is used for the actual identifier and some other property (to be agreed by the broad community as the same approach can be used outside the chem types, for instance to clarify the nature of the ID --ORCID, PMID, DOI) to indicate whether it is inChi, inchiKey, SMILES @egonw @sneumann any thoughts?