search

Bioconductor / AnnotationForge

Tools for building SQLite-based annotation data packages
https://bioconductor.org/packages/AnnotationForge
4 stars 9 forks source link

Sqlforge rnw #43

Closed villafup closed 1 year ago

villafup commented 1 year ago

@jwokaty ready for review.

Error in R CMD build: 

--- re-building ‘SQLForge.Rmd’ using knitr
Quitting from lines 2-41 (SQLForge.Rmd) 
Error: processing vignette 'SQLForge.Rmd' failed with diagnostics:
could not find function "Biocpkg"
--- failed re-building ‘SQLForge.Rmd’
hpages commented 1 year ago

Hi @villafup,

Note that the AnnotationForge package contains 4 vignettes and this PR converts 2 of them from Rnw to Rmd, MakingNewAnnotationPackages.Rnw and SQLForge.Rnw, despite the title of the PR suggesting that this work is only about the latter.

Please submit a new PR that only takes care of converting one vignette, the SQLForge.Rnw vignette. Also make sure to use a more informative title than just a file name (e.g. "Convert SQLForge.Rnw to Rmd format").

Finally please note that the main AnnotationForge repository has changed since you originally submit this PR (see https://github.com/Bioconductor/AnnotationForge/pull/42#issuecomment-1483921129), so make sure to:

  1. Resync your fork
  2. Merge your devel branch into your sqlforge-rnw branch
  3. Push
  4. Submit the new PR.

In the mean time, I'll close this PR.

Thanks!