is.atomic(NULL) is FALSE now

[antalk2]

In .isSingleStringOrNull

https://github.com/Bioconductor/AnnotationForge/blob/007e1ad51972462742b99868cc68e5cad598a5e2/R/makeOrgPackageFromNCBI.R#L811

the test is probably meant to check if x is NULL.

• The is.atomic(x) && length(x) == 0L && is not necessary
• and, due to the change in R (is.atomic(NULL) == FALSE now) it is even wrong.

https://stat.ethz.ch/pipermail/r-devel/2023-September/082892.html [Rd] is.atomic(NULL) will become FALSE Martin Maechler Mon Sep 25 17:14:58 CEST 2023

Patch to change this instance: is-atomic-NULL.patch.txt

(There may be other instances)