Bioconductor / AnnotationHub

Client for the Bioconductor AnnotationHub web resource
17 stars 13 forks source link

.Defunct display,Hub-method #36

Closed LiNk-NY closed 1 year ago

LiNk-NY commented 1 year ago

Hi Lori, @lshep

I'm marking display as defunct and removing the interactiveDisplayBase dependency. I will also prepare BiocHubsShiny (the alternative) for submission.

Best, Marcel

lshep commented 1 year ago

excellent. If its okay with you I'd like to wait until the alternate is submitted in the new package queue before merging.

lshep commented 1 year ago

When I checkout this branch locally and try to R CMD build / R CMD check I get the following:

lorikern@jbcj433:~/BioconductorPackages/SoftwarePkg$ R CMD build AnnotationHub
* checking for file 'AnnotationHub/DESCRIPTION' ... OK
* preparing 'AnnotationHub':
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
      -----------------------------------
* installing *source* package 'AnnotationHub' ...
** using staged installation
** R
** inst
** byte-compile and prepare package for lazy loading
Error in setMethod("display", signature(object = "Hub"), function(object) { : 
  no existing definition for function 'display'
Error: unable to load R code in package 'AnnotationHub'
Execution halted
ERROR: lazy loading failed for package 'AnnotationHub'
* removing '/tmp/RtmpbUDTQO/Rinstaee816145889/AnnotationHub'
      -----------------------------------
ERROR: package installation failed
LiNk-NY commented 1 year ago

Hi Lori, @lshep Thanks for pointing it out. I have fixed it. It looks like my whitespace settings on RStudio have changed the entire vignette. I will look into force updating... -MR

LiNk-NY commented 1 year ago

Update: The changes should be better reflected in the diff. Thanks!