Closed jwokaty closed 1 year ago
Thanks Jen for working on this.
I can see 3 problems with this PR:
config
variable strongly suggests that it contains the opposite of what it actually contains i.e. it's set to True
when the config
argument must be set to False
, and vice-versa. This is very miselading! Easy way to avoid this is to negate the value before assigning it to the config
variable, e.g. by doing config = not BBSutils.getNodeSpec(BBSvars.node_hostname, 'OS').find('Windows')
.sys.platform
with 'win32'
. This is how it's done everywhere else in BBS's Python code, and I think it's important to be consistent.config
is False
, what needs to be supplied to write_sys_command_version()
is the name of the executable. In the case of Java, the name of the executable is java
(lower-case), not JAVA
.So all in all, a good old if
statement should do it:
if sys.platform == 'win32':
write_sys_command_version('java', config=False)
else:
write_sys_command_version('JAVA')
Thanks again, H.
You should get the credit for this. I will close this and you can make the PR. Thanks.
Really? I could, but that was not my intention. I think you should still make the change, deploy it on the build machines, observe how it performs on the following report, adjust for any omissions or remaining issue, etc... Thanks again!
Close #332
Should be tested on devel first.