search

Bioconductor / BBS

The Bioconductor Build System
9 stars 11 forks source link

Information on info.dcf printed multiple times #397

Closed jwokaty closed 9 months ago

jwokaty commented 10 months ago

Information in package/raw-results/info.dcf is written multiple times. It should be written once. See https://bioconductor.org/checkResults/3.19/bioc-LATEST/icetea/raw-results/info.dcf as an example.

hpages commented 10 months ago

I think that the problem is that write_info_dcf() is called several times on the same package, once for each build node (e.g. 4 times in the example above). It should only be called once on each package.

So instead of being called in make_node_LeafReports() here (the make_node_LeafReports() function is called for each build node), a good place to call it would be in make_all_LeafReports() (this function is called only once) right after the creation of the raw-results/ subfolder (line 1856):

        if not no_raw_results:
            os.mkdir(os.path.join(pkg, 'raw-results'))
            write_info_dcf(pkg)

Also the function does not need to have the node_id argument.