search

Bioconductor / BiocCheck

http://bioconductor.org/packages/BiocCheck
8 stars 26 forks source link

vapply error on badViews on version 1.34.2 #184

Closed lcolladotor closed 1 year ago

lcolladotor commented 1 year ago

Hi,

I just ran into this error:

* Checking biocViews validity...
Error in vapply(badViews, function(view) { : values must be length 1,
 but FUN(X[[1]]) result is length 2
Calls: <Anonymous> -> BiocCheckRun -> checkBiocViews -> vapply

That's from https://github.com/lcolladotor/ExampleBiocWorkshop2023/actions/runs/4325676008/jobs/7552141101#step:25:50 with https://github.com/lcolladotor/ExampleBiocWorkshop2023/tree/9da41d1560ed1343b0fa7b880c5c1e94b2342db6.

It uses BiocCheck version 1.34.2 https://github.com/lcolladotor/ExampleBiocWorkshop2023/actions/runs/4325676008/jobs/7552141101#step:21:42

Best, Leo

lcolladotor commented 1 year ago

For reference, here are the biocViews terms from the DESCRIPTION file: https://github.com/lcolladotor/ExampleBiocWorkshop2023/blob/c61545067b8b3a4c50f2cc7d873a45aa7d1a69b3/DESCRIPTION#L13

LiNk-NY commented 1 year ago

Thanks Leo, it looks like that's an error in

https://github.com/Bioconductor/BiocCheck/blob/c9137fbb39e3aea109e9bec0cecccbaedadf982c/R/checks.R#L284

when there are more than one suggestions, i.e., 

c("DNASeq", "RNASeq")
LiNk-NY commented 1 year ago

Fix in dc86767d10a18ee0509e71d439ba073ab7b6137b It has also been ported to RELEASE_3_16

lcolladotor commented 1 year ago

Awesome, thanks Marcel! 🚀