search

Bioconductor / BiocCheck

http://bioconductor.org/packages/BiocCheck
8 stars 26 forks source link

Add a GitHub pull request template #87

Closed lcolladotor closed 4 years ago

lcolladotor commented 4 years ago

This pull request resolves https://github.com/Bioconductor/BiocCheck/issues/86.

As part of the commit, a new file .github/pull_request_template.md was created that contains a template file based on the GitHub instructions and the top lines at the biocthis issue template.

Ideally, this file should be properly recognized by GitHub.

The contents of the md file rely heavily on the presentation by Lori Shepard for the BiocCheck-a-thon from May 18th 2020. The contents on the presentation are available at https://docs.google.com/presentation/d/1DkN2WVPOMVGqUtlSSrWbx6IMjtGP_cEHoE3nfOEnD68/edit#slide=id.p.

This PR also adds the .github directory to the .Rbuildignore. This can clash with other PRs if they also added this line to the .Rbuildignore file.

Best, Leo

lcolladotor commented 4 years ago

Hi,

Thank you for your review comments. I just sent a new commit that addresses the review comments but also edits the NEWS and vignette files.

Best, Leo

LiNk-NY commented 4 years ago

@lcolladotor Thank you for sending this in. This is a GitHub-side change and it doesn't really affect the package. For this reason, I don't think the NEWS file should be updated.