Open lgatto opened 7 years ago
that's awesome. Thanks @lgatto
Very nice 👍 🥇
- [ ] Adjust dimensions to get an image of height 5cm, ready for printing.
- [ ] Fix hexagon not filling the full square; on the left side there is a small gap.
TODO list has been moved to sticker
issue 1.
@LiNk-NY @mtmorgan - the make_sticker
function seems to be quite useful (to me, at least). I would rather move it to a package for convenience. Would you consider it fit for BiocStyle
, for example, or should it get its own package?
New defaults
I vote for new package, maybe BiocSticker
. Developers can PR for their sticker_pkgname
function and then we can have a package of reproducible sticker collections.
p <- ggplot(aes(x = mpg, y = wt), data = mtcars) + geom_point()
p = p + theme_void() + theme_transparent()
make_sticker(p, "Bioconductor")
https://github.com/jotsetung/BioC-stickers/commit/142d1f54aa018197f80dca305a50428f7e19627b change the dimension according to https://twitter.com/robbie_bonelli/status/795211775679418372.
I vote for new package, maybe BiocSticker. Developers can PR for their
sticker_pkgname
function and then we can have a package of reproducible sticker collections.
Ok for a package; I would rather name it stickeR
or sticker
to make it more general.
If we push actual sticker creation functions in there, then this repo becomes obsolete. The advantage of an external package is that it easier for me to control what version I use for my sticker; otherwise, every change in the function (like 142d1f54aa018197f80dca305a50428f7e19627b, for example), possibly breaks stickers.
With respect to the package, having it on github
allows to install versions based on SHA commit hashes; this enables me to keep using one consistently for different stickers, as long as I record which SHA I was using upon creation.
I would only make a package of the functionality to create the stickers and would not include the actual stickers or sticker functions into that package. 1) some stickers (mine ;) ) were made manually and 2) I would simply keep functionality (the function) and results (the stickers) separate.
I realized that the hexagon is not filling the full square. On the left side there is a small gap. Could this be fixed?
I have created a sticker
package with the make_sticker
function.
@lgatto Is the function in the package different from the one we had here? I'm asking because the same code that generated this sticker https://github.com/jotsetung/BioC-stickers/blob/master/mzR/mzR.png now creates:
There have been a couple of PRs recently, but I think that the text size is also influenced by other parameters (at least that's what I observed yesterday, when preparing the pRoloc
stickers). That why we need a package and the flexibility to install a use a specific SHA has to preserve old stickers, at least until we have a stable make_sticker
.
This is because the units are in two different spaces (data and pixel).
Yup, I just reduced the size of the text - works now.
I have some ideas to improve it and create a package separately for not breaking your existing codes.
Based on @GuangchuangYu's script, I created the
make_sticker
function to make it easier to re-use and adapt. It's rough around the edges but a decent start. Suggestions and patches welcome.