Closed bschilder closed 6 months ago
Very nice stickers!
Could you please
@lgatto done!
It might be helpful to contributors to include a template README.
There's this for now in the repo's README.md:
- Each sticker should be put into a folder named according to the package.
- Each folder should also contain a README.md providing at least the name of the package and the designer/maintainer of the sticker (which is not necessarily the maintainer of the package).
But I'll add a mention about the licence.
Once comment about your licence: you use GPL, which is a software licence that defines how to re-use code, and I'm not sure to what extend it applies to the design and the actual product. I think a CC-BY would be more appropriate, but will leave it to you and still merge for now.
There is already a mention at the bottom:
Except where otherwise stated, the content and the stickers in this repository are licensed under a CC0 1.0 Universal (CC0 1.0) Public Domain License.
Once comment about your licence: you use GPL, which is a software licence that defines how to re-use code, and I'm not sure to what extend it applies to the design and the actual product. I think a CC-BY would be more appropriate, but will leave it to you and still merge for now.
Ok, so when you ask for the license to be added to the package-specific readme are you asking for the software license or the sticker license? would be good to clarify in the readme instructions. I suppose I could see an argument for having a separate license for the software and the sticker, but this makes things a bit confusing as well.
It depends if you have code in your repo (you don't) and/or only a sticker. The code would likely not fall under a licence, as it would mostly be a script that uses other packages, but again, up to you. The main asserts that are distributed in this repo are stickers, hence a licence for stickers.
Please feed free to open a PR if the main README.md file needs more details.
Adding stickers for 3 Bioc packages from our lab:
Thanks! -Brian