search

Bioconductor / BiocStyle

Issues and pull requests for BiocStyle should go here.
12 stars 19 forks source link

`fig.small` figures are only displayed when the browser window is sufficiently narrow #83

Closed mtmorgan closed 3 years ago

mtmorgan commented 3 years ago

See https://stat.ethz.ch/pipermail/bioc-devel/2020-November/017483.html

AIB-KQC commented 3 years ago

could you show me the picture? Thank you.

sudeepsahadevan commented 3 years ago

Hi @AIB-KQC Here is one of the pictures that didn't render properly image_issue

aoles commented 3 years ago

Thanks @grimbough for looking into it!

The problem appears also in the BiocStyle vignette itself, both in release and devel. The small figures seem to be broken for a while now, as they don't show up in the vignette on the 3.11 branch compiled on September 20 as well.

grimbough commented 3 years ago

Yes, I think this is related to the changes on knitr that also caused #78 but this time it's a subtle difference rather than a breaking change. That's why we see it with the old version of BiocStyle, because it's still using the most recent knitr.

I think knitr now sets a out.width if one isn't specified, and this overrides or negates the "100%" BiocStyle tries to set. Short term fix is probably to put out.width="100%" in the chunk options, and then I'll try to get a patch that restores the old behaviour.

grimbough commented 3 years ago

Hopefully this is now fixed in BiocStyle versions 2.18.1 and 2.19.1. @sudeepsahadevan please let us know if it's still an issue.

sudeepsahadevan commented 3 years ago

Thank you @grimbough,

Now class "smallfigure" images are rendered properly.