search

Bioconductor / BiocStyle

Issues and pull requests for BiocStyle should go here.
12 stars 19 forks source link

Patch issue with out.width for smallfigure and widefigure environments #84

Closed grimbough closed 3 years ago

grimbough commented 3 years ago

This addresses #83

I think the move of knitr:::fix_options() to after the hooks have been run, rather than before, has affected how the out.width parameter is set. I don't know why the new defaults make the figure disappear, the resulting image still has a width in the output HTML, but my understanding of the code is that we want this to be "100%" unless the user explicitly defines it in the chunk options.

This patch tries to achieve that, and includes some new unit tests to check that correct width attribute is assigned in the output HTML file.

sudeepsahadevan commented 3 years ago

Thanks a lot @grimbough and @aoles!